Editorial: use empty <span> for old ID #11128
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the style used in many other places to keep old IDs working. Doing this consistently will make it easier to detect this pattern and transform it to oldids="" for Bikeshed, and makes it clear in the source that the <span> isn't creating a link, as they usually do.
|
Another thing I found in whatwg/html-build#296. In this case there isn't anything wrong and this change isn't strictly needed, it's just nice to have it out of the way. |
annevk
approved these changes
Mar 12, 2025
|
I merged as "Meta:" because that seemed more appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the style used in many other places to keep old IDs working.
Doing this consistently will make it easier to detect this pattern and
transform it to oldids="" for Bikeshed, and makes it clear in the source
that the isn't creating a link, as they usually do.
/system-state.html ( diff )