Add missing group change types #355
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add the missing group v2 change message types. This is literally "it compiles so I'm gonna push it" so it's possible, likely even, that I'm doing a thing or two wrong. I just looked how the parsing works for the existing message types and extrapolated from there. This is somewhere between a draft PR and a RFC...
I was expecting the handling to be absent here, but the parsing was pretty much complete, just missing the newer additions. So this means that this is just the tip of the iceberg and the client has to handle all those messages. Independently of this PR, I can start working on Whisperfish already. Other clients are most welcome to join the improve-a-thon!