Improvements for Magnify, Avalonia 11.2.3, fixes for MacOS #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wieslawsoltes,
I'd like to merge our fixes we implemented to your official repository.
There are addressed issues we found when using your code.
As I've done this changes few months ago I do not exactly remmember the cases.
In my opinion the only change you could have comments are changes in the method Border_PointerWheelChanged.
For MacOS we found that when you scroll then Detlta is always 1 but when you use touchpad then it's double value.
We'd like to have panning on touch pad and scroll only when command button pressed.
In case you don't like such change I propose to extract the implementation to separate protected method which could be override.
Thanks for your work!