Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/sage mod mass #102

Merged
merged 2 commits into from
May 10, 2024
Merged

Patch/sage mod mass #102

merged 2 commits into from
May 10, 2024

Conversation

picciama
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

fixes a rounding issue in the constants to make carbamidomethylation mass delta matching work

Technical details

Additional context

@picciama picciama self-assigned this May 10, 2024
@picciama picciama linked an issue May 10, 2024 that may be closed by this pull request
Rescoring the Sage output doesn't work wilhelm-lab/oktoberfest#211
Closed
@picciama picciama changed the base branch from development to main May 10, 2024 06:43
@picciama picciama merged commit 9a99f40 into main May 10, 2024
26 checks passed
@picciama picciama deleted the patch/sage_mod_mass branch July 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@picciama picciama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rescoring the Sage output doesn't work
1 participant
@picciama