Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
Technical details
Instead of just adding a potential n-term mod mass to the first aa position before adding all other mod masses to the respecitve aa masses, the n-term mod mass is removed from the mod dictionary mapping the mod positions in the aa sequence to their mass. Since n-term mods are stored at position -2, this lead to y2-yn ions getting it added by mistake after calculating the cumsum.
Additional context