Implode - empty string bug - fix

wniemiec-util-java · Feb 24, 2022 · 4f233d5 · 4f233d5
1 parent 771aa2e
commit 4f233d5
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/dist/1.x/string-utils-1.1.1.jar b/dist/1.x/string-utils-1.1.1.jar
diff --git a/pom-mavencentral.xml b/pom-mavencentral.xml
@@ -6,7 +6,7 @@
 
   <groupId>io.github.wniemiec-util-java</groupId>
   <artifactId>string-utils</artifactId>
-  <version>1.1.0</version>
+  <version>1.1.1</version>
   <name>StringUtils</name>
   <description>Contains methods that perform string manipulation.</description>
   <url>https://github.com/wniemiec-util-java/string-utils</url>

diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
   <groupId>wniemiec.util.java</groupId>
   <artifactId>string-utils</artifactId>
-  <version>1.1.0</version>
+  <version>1.1.1</version>
   <name>StringUtils</name>
   <description>Contains methods that perform string manipulation.</description>
   <url>https://github.com/wniemiec-util-java/string-utils</url>

diff --git a/src/main/java/wniemiec/util/java/StringUtils.java b/src/main/java/wniemiec/util/java/StringUtils.java
@@ -44,7 +44,9 @@ public static <T> String implode(List<T> list, String delimiter) {
             response.append(delimiter);
         }
 
-        removeLastCharacter(response);
+        if (!delimiter.isEmpty()) {
+            removeLastCharacter(response);
+        }
 
         return response.toString();
     }

diff --git a/src/test/java/wniemiec/util/java/StringUtilsTest.java b/src/test/java/wniemiec/util/java/StringUtilsTest.java
@@ -14,6 +14,14 @@ void testHelloWorld() {
 
         Assertions.assertEquals("hello world", obtained);
     }
+
+    @Test
+    void testHelloWorldEmptyDelimiter() {
+        List<String> items = List.of("hello", "world");
+        String obtained = StringUtils.implode(items, "");
+
+        Assertions.assertEquals("helloworld", obtained);
+    }
 
     @Test
     void testNullList() {