Skip to content

Commit

Permalink
Fix bug: goo details were being fetched from scratch for all the foil…
Browse files Browse the repository at this point in the history
… cards, due to left-over conversion of appID to int
  • Loading branch information
woctezuma committed Nov 22, 2023
1 parent d6206b8 commit 8e02ab1
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/market_foil_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -758,14 +758,9 @@ def download_missing_goo_details(
verbose=verbose,
)

# Convert appIDs to integers, because:
# - dictionary keys are strings in 'all_goo_details',
# - appIDs are stored as integers in 'groups_by_app_id'.
app_ids_with_known_goo_details = [int(app_id) for app_id in all_goo_details]

all_app_ids = set(groups_by_app_id)
app_ids_with_unknown_goo_details = all_app_ids.difference(
app_ids_with_known_goo_details,
all_goo_details,
)

eligible_enforced_app_ids_to_process = all_app_ids.intersection(
Expand Down

0 comments on commit 8e02ab1

Please sign in to comment.