Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #51

Merged
merged 34 commits into from
Nov 20, 2023
Merged

Refactoring #51

merged 34 commits into from
Nov 20, 2023

Conversation

woctezuma
Copy link
Owner

  • Use str for appIDs, instead of int (which were converted to str when loaded from / saved to JSON)
  • Move utilitary functions to src/
  • Fix errors raised by mypy
  • Fix issues raised by refurb
  • Lint and format with ruff
  • Fix grammar and typos
  • Trim README
  • Update some data snapshots

@woctezuma
Fix errors raised by mypy (WIP)
a4bdcd3
@woctezuma
Fix errors raised by mypy (WIP again)
bde779c
@woctezuma
Apply ruff
b8142e3
@woctezuma
Fix inconsistency: free_apps should be a set, not a list
c11f8ec
@woctezuma
Refactoring: move files to src/
a45773a
@woctezuma
README: prepend src/ to file locations after refactoring
68dab27
@woctezuma
Fix all the errors raised by mypy
8526d8c
@woctezuma
Remove unused functions
d9353a2
@woctezuma
Refactoring: move utils out of main scripts
d29703d
@woctezuma
Fix grammar and minor typos
5d32704
@woctezuma
Add mypy to pre-commit
c4b6d2d
@woctezuma
Fix pre-commit for mypy: add the types-requests dependency
22c2afd
@woctezuma
Reorder pre-commit hooks based on expected runtime
8466bee
@woctezuma
Fix FURB123 (refurb): Replace str(x) with x
f5e2f89
@woctezuma
Fix FURB124 (refurb): Replace x == y and z == y with x == y == z
9c9bfab
@woctezuma
Fix FURB123 (refurb): Replace list(x) with x.copy()
28ad42f
@woctezuma
Format pre-commit config
ab8b013
@woctezuma
Fix imports
34329dc
@woctezuma
Data: update catalog of craftable booster packs
bea0ac5
@woctezuma
README: add a hyperlink for sacks of gems
ff417d2
@woctezuma
README: add a local link for drop-rate estimates
fb7d752
@woctezuma
README: remove basic functions in Usage
cdee8a9
@woctezuma
README: update entries in the example of a cookie
ffed56e
@woctezuma
README: remove the walkthrough based on Augmented Steam
95d7237
@woctezuma
README: shorten sentences
c61a4dc
@woctezuma
README: shorten a sentence in Usage
49dd619
@woctezuma
README: fix a typo (crafed -> crafted)
bf435d3
@woctezuma
README: fix a typo (a fill-in [noun] -> to fill in [verb])
fdcbb12
@woctezuma
README: update the number of crafted badges
f7e2db1
@woctezuma
Fix bug: suppress KeyError
f562d9b
@woctezuma woctezuma added the enhancement New feature or request label Nov 20, 2023
@woctezuma woctezuma self-assigned this Nov 20, 2023
@woctezuma woctezuma merged commit cd4f620 into master Nov 20, 2023
1 check passed
@woctezuma woctezuma deleted the mypy branch November 20, 2023 10:19
@woctezuma woctezuma restored the mypy branch November 20, 2023 10:20
@woctezuma woctezuma deleted the mypy branch November 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@woctezuma woctezuma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woctezuma