Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icu package update #41342

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

debasishbsws
Copy link
Member

This require handling it differently even though the ABI check pass. there is a ABI diffrence in this version and result in fail of downstream packages.

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 5, 2025
xnox
xnox previously requested changes Feb 5, 2025
Copy link
Member

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debasishbsws @imjasonh @jonjohnsonjr @ajayk

Please correct me if anything below is wrong:

Bumping all the things in a single PR does not guarantee that the new icu will be used to compile these dependants.

One most likely needs to land this separately - as in land icu in one PR into main; wait for it to build and publish; then land pr(s) with lots of wolfictl bumps. However such PRs will not do testing of this.

To pre-test such rebuilds, you can use staging to do rebuild with the icu rebuild draft PR. But there is another option with pure github:

  • open icu pr (1), keep it draft wait for it to build
  • open a new pr with wolfictl bumps AND also add the wolfi-presubmit repository from (1) above as build_repositories in the environment of all of these files

Such PR is not ok to merge into main; but it will correctly retest all builds against the new ICU abi; and will be summarised with build/test failures.

EDIT: wait, I think I am wrong. Because looking at successful builds:
https://apk.chaindag.dev/https/apk.cgr.dev/wolfi-presubmit/9818cc3e9849f05c67c8ab2bce6b32cc92faec1d/aarch64/libarrow-19.0.0-r2.apk@etag:a4012c49af1ceed2275030aa50a50ce0/.PKGINFO

the rebuild of apache did pick up the new icu 76 abi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants