Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip(file.yaml): test patch for bug #612 #41388

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented Feb 5, 2025

The patch refers the commits:

  • cd534c3a08c28ccd8701c900d9c45b8d278212d8
  • b874d520c592ecd55ebcae0d662dc6e54f5c5414

based on the update about the fix on bug tracker [1].

  1. https://bugs.astron.com/view.php?id=612#c4156

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@maxgio92 maxgio92 force-pushed the file/upstream-issue-612 branch from a689e24 to c2f2a62 Compare February 5, 2025 15:03
Copy link
Contributor

octo-sts bot commented Feb 5, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: magic/cad, 46: Warning: incomplete magic '>(2.s*2) ulong x'

• Error Category: Configuration/Syntax

• Failure Point: Magic pattern file syntax validation during compilation

• Root Cause Analysis: The magic pattern file contains an invalid or malformed pattern definition at line 46 of magic/cad. The pattern syntax appears to be incomplete or incorrect.

• Suggested Fix:

  1. Add zlib support by adding to environment.packages:
environment:
  contents:
    packages:
      - zlib-dev
      - bzip2-dev
      - xz-dev
      - zstd-dev
  1. Update the magic pattern file location in the configure step:
  - name: Configure
    runs: |
      ./configure \
         --host=${{host.triplet.gnu}} \
         --target=${{host.triplet.gnu}} \
         --prefix=/usr \
         --datadir=/usr/share \
         --with-magic-pattern-dir=/usr/share/misc/magic

• Explanation: The file utility relies heavily on magic pattern files for file type detection. The error suggests there's a syntax issue in one of these pattern files. Additionally, adding compression library support will improve file type detection capabilities.

• Additional Notes:

  • The magic pattern syntax requires careful formatting
  • Compression library support is recommended for better file type detection
  • Verify the magic pattern file permissions and location
  • Consider adding runtime tests to verify pattern file parsing

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 5, 2025
The patch refers the commits:
- cd534c3a08c28ccd8701c900d9c45b8d278212d8
- b874d520c592ecd55ebcae0d662dc6e54f5c5414

based on the update about the fix on bug tracker [1].

1. https://bugs.astron.com/view.php?id=612#c4156

Signed-off-by: Massimiliano Giovagnoli <massimiliano.giovagnoli@chainguard.dev>
@maxgio92 maxgio92 force-pushed the file/upstream-issue-612 branch from c2f2a62 to 3611c72 Compare February 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant