-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hydra to pkgs #41510
Add hydra to pkgs #41510
Conversation
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this, just couple of questions and suggestions
Possibly only this needs a little addressing #41510 (comment) |
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
I missed that comment @mritunjaysharma394. Now with the last few commits I think I was able to resolve them all. Thank you for nudge in the right direction. |
Thanks @anushkamittal20 , just some small final suggestions hopefully |
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Thanks for being patient with the reviews, lgtm, great work! |
Fixes: New package
Related: N/A
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches