Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydra to pkgs #41510

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Add hydra to pkgs #41510

merged 13 commits into from
Feb 19, 2025

Conversation

anushkamittal20
Copy link
Contributor

@anushkamittal20 anushkamittal20 commented Feb 6, 2025

Fixes: New package

Related: N/A

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 6, 2025
anushkamittal20 and others added 3 commits February 6, 2025 19:27
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
@anushkamittal20 anushkamittal20 marked this pull request as ready for review February 19, 2025 11:04
Copy link
Contributor

@mritunjaysharma394 mritunjaysharma394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, just couple of questions and suggestions

Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
@mritunjaysharma394
Copy link
Contributor

Possibly only this needs a little addressing #41510 (comment)

Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
@anushkamittal20
Copy link
Contributor Author

I missed that comment @mritunjaysharma394. Now with the last few commits I think I was able to resolve them all. Thank you for nudge in the right direction.

@mritunjaysharma394
Copy link
Contributor

Thanks @anushkamittal20 , just some small final suggestions hopefully

Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
Signed-off-by: anushkamittal20 <anushka.mittal@chainguard.dev>
@mritunjaysharma394
Copy link
Contributor

Thanks for being patient with the reviews, lgtm, great work!

@mritunjaysharma394 mritunjaysharma394 merged commit 99a6f13 into wolfi-dev:main Feb 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants