-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsyslog: add other plugins and expand tests #41568
Conversation
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
702fd24
to
97b7bfc
Compare
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
97b7bfc
to
cfdfd5b
Compare
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, modulo some more comments
@wojciechka - for some reason I couldn't reply in the discussion, but as per your comment:
I've tried that but |
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!! I think the behavior before and after refactoring is not changing so I think this looks good.
Some minor comments/suggestions inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!! looks good to me, mostly looks non-breaking because before and after package is same and we're introducing more plugins via this commit. Will keep an eye on dependents.
See: https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/rsyslog/APKBUILD
rsyslog supports lots of other systems so in order to enable those, some build-time deps are needed. Also introduce a new
plugins
subpackages so those can beapk add
able individually.rsyslog-plugins-all
may needed for the image. (Similar structure asopenldap
package building)