Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsyslog: add other plugins and expand tests #41568

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented Feb 6, 2025

See: https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/rsyslog/APKBUILD

rsyslog supports lots of other systems so in order to enable those, some build-time deps are needed. Also introduce a new plugins subpackages so those can be apk addable individually. rsyslog-plugins-all may needed for the image. (Similar structure as openldap package building)

Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax marked this pull request as draft February 6, 2025 20:57
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 6, 2025
@Dentrax Dentrax changed the title rsyslog: add plugins rsyslog: add other plugins and expand tests Feb 6, 2025
@Dentrax Dentrax force-pushed the rsyslog-plugins branch 2 times, most recently from 702fd24 to 97b7bfc Compare February 6, 2025 21:22
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@Dentrax Dentrax marked this pull request as ready for review February 6, 2025 22:27
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Copy link
Member

@wojciechka wojciechka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, modulo some more comments

@Dentrax
Copy link
Member Author

Dentrax commented Feb 7, 2025

@wojciechka - for some reason I couldn't reply in the discussion, but as per your comment:

Perhaps group them at the end and leave a comment why they are commented out?

I've tried that but yam complains it and rearrange by alphabetical order.

Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!! I think the behavior before and after refactoring is not changing so I think this looks good.

Some minor comments/suggestions inline.

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! looks good to me, mostly looks non-breaking because before and after package is same and we're introducing more plugins via this commit. Will keep an eye on dependents.

@Dentrax Dentrax merged commit edfc294 into wolfi-dev:main Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants