Set specific flags for html_entity_decode

woocommerce · Jan 16, 2025 · c92acd5 · c92acd5
1 parent f88648c
commit c92acd5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Ads/AccountService.php b/src/Ads/AccountService.php
@@ -78,7 +78,7 @@ public function get_connected_account(): array {
 		$status = [
 			'id'       => $id,
 			'currency' => $this->options->get( OptionsInterface::ADS_ACCOUNT_CURRENCY ),
-			'symbol'   => html_entity_decode( get_woocommerce_currency_symbol( $this->options->get( OptionsInterface::ADS_ACCOUNT_CURRENCY ) ) ),
+			'symbol'   => html_entity_decode( get_woocommerce_currency_symbol( $this->options->get( OptionsInterface::ADS_ACCOUNT_CURRENCY ) ), ENT_QUOTES ),
 			'status'   => $id ? 'connected' : 'disconnected',
 		];
 

diff --git a/src/MerchantCenter/MerchantStatuses.php b/src/MerchantCenter/MerchantStatuses.php
@@ -427,7 +427,7 @@ protected function get_product_issues( array $statuses ): array {
 			}
 
 			$product_issue_template = [
-				'product'              => html_entity_decode( $wc_product->get_name() ),
+				'product'              => html_entity_decode( $wc_product->get_name(), ENT_QUOTES ),
 				'product_id'           => $wc_product_id,
 				'created_at'           => $created_at,
 				'applicable_countries' => [],

diff --git a/tests/Unit/MerchantCenter/MerchantStatusesTest.php b/tests/Unit/MerchantCenter/MerchantStatusesTest.php
@@ -624,7 +624,7 @@ function ( $value ) use ( $variable_product ) {
 		$this->merchant_issue_query->expects( $this->once() )->method( 'update_or_insert' )->with(
 			[
 				[
-					'product'              => html_entity_decode( $product_1->get_name() ),
+					'product'              => html_entity_decode( $product_1->get_name(), ENT_QUOTES ),
 					'product_id'           => $product_1->get_id(),
 					'created_at'           => $this->merchant_statuses->get_cache_created_time()->format( 'Y-m-d H:i:s' ),
 					'applicable_countries' => json_encode( [ 'ES' ] ),