-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-1] Enable users to seamlessly set up conversion tracking, without having to set up merchant center first or requiring campaign creation #2205
Conversation
Make merchant account non-required for ads account setup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2205 +/- ##
===========================================
- Coverage 64.5% 62.2% -2.3%
+ Complexity 4252 4209 -43
===========================================
Files 458 748 +290
Lines 18041 21615 +3574
Branches 0 533 +533
===========================================
+ Hits 11634 13436 +1802
- Misses 6407 7727 +1320
- Partials 0 452 +452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…-step1-followup Move useGoogleAccountCheck to its own file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox. I think this is getting close. The main thing that needs updating is the API handling for linking the Ads and MC accounts and updating PHPUnit and E2E tests. I've taken a pass at getting most of this working in #2223. Feel free to merge those into this branch if you'd like and handle additional test updates here.
Update tests for conversion tracking without a merchant account
This makes sure HTTP errors are handled correctly when the server returns an error code and returns a callback to avoid loops. The callback name in CreateAccount has also been updated for consistency.
…te-flow R-1.3 Add Google Ads invite acceptance flow
Update E2E tests for setup flow with Ads setup in Step 1
Change the merge base to the new feature branch I will be merging this PR. The subsequent PRs will also use the |
f16a8b4
into
feature/seamlessly-conversion-tracking
Changes proposed in this Pull Request:
Make improvements to ads conversion tracking experience, including the ability to set-up conversion tracking without needing to complete full onboarding flow
Users should be able to connect to Google ads account in step-1 of the onboarding flow.
Closes #2215.
Detailed description
Current Issue
In the current onboarding journey, user has to go through the Merchant Account center setup in order to connect to the ads account which will eventually setup the conversion tracking. This creates a dependency between ads and merchant account which should not be the case and user should be able to setup conversion tracking without having to setup the merchant account.
Changes in the PR
Screenshots:
Detailed test instructions:
a. Jetpack
b. Google
c. Google Ads
d. Google Merchant Center
Changelog entry