WordPress 6.7 Compatibility: Fix the issue that E2E test can't log in to wp-admin

[eason9487]

Changes proposed in this Pull Request:

With WordPress 6.7-RC3, the E2E test failed to start due to match two elements when trying to click the "Log In" button.

Trying to log-in as admin...
Admin log-in failed, Retrying... 0/5
locator.click: Error: strict mode violation: locator('text=Log In') resolved to 2 elements:
    1) <h1 class="screen-reader-text">Log In</h1> aka getByRole('heading', { name: 'Log In' })
    2) <input type="submit" id="wp-submit" value="Log In" name="wp-submit" class="button button-primary button-large"/> aka getByRole('button', { name: 'Log In' })

This PR ensures that it can locate the "Log In" button.

📌 The failed test case will be handled in a separate RP.

Detailed test instructions:

1. View the failed run: https://github.com/woocommerce/google-listings-and-ads/actions/runs/11774628750/job/32793771070#step:10:20
2. View the successful log-in run: https://github.com/woocommerce/google-listings-and-ads/actions/runs/11775116109/job/32794945918#step:10:18

Changelog entry

Dev - WordPress 6.7 Compatibility: Fix the issue that E2E test can't log in to wp-admin.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7%. Comparing base (0383264) to head (1f90028).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #2668   +/-   ##
=======================================
  Coverage     62.7%   62.7%           
=======================================
  Files          319     319           
  Lines         5074    5074           
  Branches      1231    1231           
=======================================
  Hits          3180    3180           
  Misses        1721    1721           
  Partials       173     173           

Flag	Coverage Δ
js-unit-tests	62.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[mikkamp]

Thanks for the change, I can confirm that there is another element on the page with the same text:

<h1 class="screen-reader-text">Log In</h1>

With the included fix it selects only the log in button.

The code to login as admin was originally copied over from WooCommerce, but it looks like it was refactored to use a helper utility where they use the same selector as you do here: https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/tests/e2e-pw/utils/login.js

Just curious if some of those other tweaks are needed as well, but no reason to fix something that isn't broken. So I'll go ahead and approve the PR.

[eason9487]

Hi @mikkamp, thanks for the review!

Just curious if some of those other tweaks are needed as well, [...]

The current login process looks good. I think we can keep it as it is.