Remove vendor files that prints php information phpinfo()
#2673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
SIRT: p3btAN-2W0-p2
This PR removes a Google Ads API file
vendor/googleads/google-ads-php/scripts/print_php_information.php
that prints the php information usingphpinfo()
.There is already a script
bin/cleanup-vendor-files.sh
that removes the unneeded vendor files, adding one more removal there.The file wasn't used anywhere in the code, so it's safe to remove it after
composer install
.I also checked other files under
vendor/
folder and confirmed no one is also callingphpinfo()
.What does
vendor/googleads/google-ads-php/scripts/print_php_information.php
do?It's mainly used in googleads/google-ads-php repo when anyone creates a bug report issue, they recommend the issue opener attaches the output of that script.
Ref: googleads/google-ads-php#466
Detailed test instructions:
How to reproduce it
develop
branch by runningnvm use && npm i && composer install && npm run build
google-listing-and-ads.zip
that just being built in your sitehttps://<your-site>/wp-content/plugins/google-listings-and-ads/vendor/googleads/google-ads-php/scripts/print_php_information.php
, replace<your-site>
with your site's URL.How to test it
nvm use && npm i && composer install && npm run build
google-listing-and-ads.zip
that just being built in your sitehttps://<your-site>/wp-content/plugins/google-listings-and-ads/vendor/googleads/google-ads-php/scripts/print_php_information.php
, replace<your-site>
with your site's URLAdditional details:
Changelog entry