-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GTIN] Hide / disable GTIN also when YOAST is active. #2685
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add/support-core-gtin-field #2685 +/- ##
===============================================================
+ Coverage 64.7% 65.2% +0.5%
- Complexity 4662 4674 +12
===============================================================
Files 799 478 -321
Lines 24627 19545 -5082
Branches 1242 0 -1242
===============================================================
- Hits 15936 12737 -3199
+ Misses 8518 6808 -1710
+ Partials 173 0 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this extra scenario. It's working as expected. It took me a bit to understand how the field switches input type and why we are copying attributes from a different class. But I think that's more down to the decisions that were made in how to structure the field.
Co-authored-by: Mik <mikkamp@users.noreply.github.com>
Changes proposed in this Pull Request:
Closes part of #2617
This PR fixes a Bug in which GTIN is not hidden or disabled when YOAST is activated.
Screenshots:
Detailed test instructions:
gla_install_version
as 2.8.6gla_install_version
as 2.8.8Additional details:
Changelog entry