Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests in WC 9.6 #2755

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix E2E tests in WC 9.6 #2755

merged 1 commit into from
Jan 9, 2025

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jan 9, 2025

Changes proposed in this Pull Request:

E2E tests were failing for 9.6.0-beta.2

The reason is that the store is in Coming Soon mode for Store pages. I adapted the Install Script to set the Store as Live

Screenshots:

Screenshot 2025-01-09 at 10 35 11

Detailed test instructions:

  1. See the tests passing against WC 9.6.0-beta.2
  2. See the tests passing against WC latest

Additional details:

Changelog entry

Dev - Fix E2E tests in WC 9.6

@puntope puntope self-assigned this Jan 9, 2025
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jan 9, 2025
@puntope puntope marked this pull request as ready for review January 9, 2025 10:03
@puntope puntope requested a review from a team January 9, 2025 10:03
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@puntope puntope merged commit 23419b9 into develop Jan 9, 2025
9 of 10 checks passed
@puntope puntope deleted the dev/fix-e2e-9.6 branch January 9, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants