Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent usage of ContainerAware #2761

Merged
merged 17 commits into from
Jan 14, 2025

Merge develop

763cde0
Select commit
Loading
Failed to load commit list.
Merged

Consistent usage of ContainerAware #2761

Merge develop
763cde0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

67.0% (-0.1%) compared to c8c1efa

View this Pull Request on Codecov

67.0% (-0.1%) compared to c8c1efa

Details

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.0%. Comparing base (c8c1efa) to head (763cde0).

Files with missing lines Patch % Lines
...ernal/DependencyManagement/CoreServiceProvider.php 0.0% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2761     +/-   ##
===========================================
- Coverage       67.0%   67.0%   -0.1%     
+ Complexity      4692    4684      -8     
===========================================
  Files            480     480             
  Lines          19601   19581     -20     
===========================================
- Hits           13141   13116     -25     
- Misses          6460    6465      +5     
Files with missing lines Coverage Δ
src/API/Google/Middleware.php 95.7% <ø> (-<0.1%) ⬇️
src/API/Google/Settings.php 6.3% <ø> (-1.2%) ⬇️
src/API/Site/Controllers/Ads/ReportsController.php 93.8% <ø> (ø)
src/API/Site/Controllers/BaseReportsController.php 75.9% <ø> (-0.8%) ⬇️
...e/Controllers/MerchantCenter/ReportsController.php 91.8% <ø> (ø)
...trollers/MerchantCenter/ShippingTimeController.php 92.9% <ø> (-0.1%) ⬇️
src/API/Site/RESTControllers.php 100.0% <ø> (+14.3%) ⬆️
src/Admin/BulkEdit/BulkEditInitializer.php 66.7% <ø> (ø)
src/Ads/AccountService.php 98.7% <100.0%> (-<0.1%) ⬇️
src/ConnectionTest.php 0.0% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes