Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension set support to activation tests #242

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

singerb
Copy link
Contributor

@singerb singerb commented Jan 28, 2025

Requires https://github.com/Automattic/compatibility-dashboard/pull/1196

Fixes https://github.com/Automattic/woocommerce.com/issues/22982

This PR allows the local activation test running to use the --extension_set argument. It relies on this information being added to the sync data in the linked PR. Note that this relies on the usual access controls in order to be able to download the extensions listed in the set, so most vendor accounts will not be able to use it.

Testing:

  • Deploy the linked PR to staging.
  • Switch your backend to staging and/or resync.
  • Test ./qit run:activation --extension_set=minimal <extension to test>; verify that the extra extensions get activated during the test steps.
  • Verify a run without an extension set still works as expected.
  • Test around this issue.

@singerb singerb requested a review from a team January 28, 2025 20:48
@singerb
Copy link
Contributor Author

singerb commented Jan 28, 2025

@Luc45 I may need some notes here on how to get phpunit to pass; looks like an ordering issue with the commands?

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested great for me, happy to add my approval so it's ready to go once the unit tests are figured out.

@MrJnrman
Copy link
Contributor

looks like an ordering issue with the commands?

Looks like you're missing the option declaration extension_set option from the UpEnvironmentCommand class.

Copy link
Contributor

@MrJnrman MrJnrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great! Unit tests seem to be a quick fix so I'm happy to add a approval. Feel free to merge once you get the tests to pass

@singerb
Copy link
Contributor Author

singerb commented Jan 29, 2025

looks like an ordering issue with the commands?

Looks like you're missing the option declaration extension_set option from the UpEnvironmentCommand class.

No that should be there; it's dynamic from the schema.

@Luc45
Copy link
Member

Luc45 commented Jan 29, 2025

@singerb I'm looking into those tests now.

@singerb singerb merged commit 7707dd0 into trunk Feb 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants