-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension set support to activation tests #242
Conversation
@Luc45 I may need some notes here on how to get phpunit to pass; looks like an ordering issue with the commands? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested great for me, happy to add my approval so it's ready to go once the unit tests are figured out.
Looks like you're missing the option declaration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great! Unit tests seem to be a quick fix so I'm happy to add a approval. Feel free to merge once you get the tests to pass
No that should be there; it's dynamic from the schema. |
@singerb I'm looking into those tests now. |
Update mocked schema for unit tests
Requires https://github.com/Automattic/compatibility-dashboard/pull/1196
Fixes https://github.com/Automattic/woocommerce.com/issues/22982
This PR allows the local activation test running to use the
--extension_set
argument. It relies on this information being added to the sync data in the linked PR. Note that this relies on the usual access controls in order to be able to download the extensions listed in the set, so most vendor accounts will not be able to use it.Testing:
./qit run:activation --extension_set=minimal <extension to test>
; verify that the extra extensions get activated during the test steps.