Skip to content

Commit

Permalink
[Brand Updates] Add missing periods to Empty State messages (#14940)
Browse files Browse the repository at this point in the history
  • Loading branch information
hichamboushaba authored Jan 23, 2025
2 parents a02ee50 + 834f540 commit eb83f4f
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 32 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ private extension BlazeCampaignListView {
static let create = NSLocalizedString("Create", comment: "Title of the button to create a new campaign on the Blaze campaign list view")
static let emptyStateTitle = NSLocalizedString("No campaigns yet", comment: "Title of the empty state of the Blaze campaign list view")
static let emptyStateMessage = NSLocalizedString(
"Drive more sales to your store with Blaze",
"Drive more sales to your store with Blaze.",
comment: "Subtitle of the empty state of the Blaze campaign list view"
)
static let done = NSLocalizedString("Done", comment: "Button to dismiss the Blaze campaign detail view")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ extension BlazeTargetLocationPickerViewModel {
enum Localization {
static let searchViewHintMessage = NSLocalizedString(
"blazeTargetLocationPickerViewModel.searchViewHintMessage",
value: "Start typing country, state or city to see available options",
value: "Start typing country, state or city to see available options.",
comment: "Hint message to enter search query on the target location picker for campaign creation"
)
static let longerQuery = NSLocalizedString(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ extension CustomFieldsListHostingController {
static let emptyStateDescription = NSLocalizedString(
"customFieldsListHostingController.emptyStateDescription",
value: "Custom fields are optional metadata to display extra information or customize "
+ "your store's shopping experience",
+ "your store's shopping experience.",
comment: "Message when the list is empty."
)
static let emptyStateButton = NSLocalizedString(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private extension CustomersListView {
value: "No customers yet",
comment: "Title when there are no customers to show in the Customers list screen.")
static let emptyStateMessage = NSLocalizedString("customerList.emptyStateMessage",
value: "Create an order to start gathering customer insights",
value: "Create an order to start gathering customer insights.",
comment: "Message when there are no customers to show in the Customers list screen.")
static let searchPlaceholder = NSLocalizedString("customersList.searchPlaceholder",
value: "Search for customers",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ private extension DashboardView {

static let subtitle = NSLocalizedString(
"dashboardView.shareStoreCard.subtitle",
value: "Use email or social media to spread the word about your store",
value: "Use email or social media to spread the word about your store.",
comment: "Subtitle of the Share Your Store card"
)

Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private extension Inbox {
static let title = NSLocalizedString("Inbox", comment: "Title for the screen that shows inbox notes.")
static let emptyStateTitle = NSLocalizedString("Congrats, you’ve read everything!",
comment: "Title displayed if there are no inbox notes in the inbox screen.")
static let emptyStateMessage = NSLocalizedString("Come back soon for more tips and insights on growing your store",
static let emptyStateMessage = NSLocalizedString("Come back soon for more tips and insights on growing your store.",
comment: "Message displayed if there are no inbox notes to display in the inbox screen.")
static let dismissAllNotes = NSLocalizedString("Dismiss All",
comment: "Dismiss All button in Inbox Notes for dismissing all the notes.")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ private extension OrderListViewController {
enum Localization {
static let allOrdersEmptyStateMessage = NSLocalizedString("Waiting for your first order",
comment: "The message shown in the Orders → All Orders tab if the list is empty.")
static let allOrdersEmptyStateDetail = NSLocalizedString("Explore how you can increase your store sales",
static let allOrdersEmptyStateDetail = NSLocalizedString("Explore how you can increase your store sales.",
comment: "The detailed message shown in the Orders → All Orders tab if the list is empty.")
static let learnMore = NSLocalizedString("Learn more", comment: "Title of button shown in the Orders → All Orders tab if the list is empty.")
static let createTestOrderDetail = NSLocalizedString(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ private extension ProductVariationsViewController {
enum Localization {
static let emptyStateTitle = NSLocalizedString("Create your first variation",
comment: "Title on the variations list screen when there are no variations")
static let emptyStateSubtitle = NSLocalizedString("To add a variation, you'll need to set its attributes (ie \"Color\", \"Size\") first",
static let emptyStateSubtitle = NSLocalizedString("To add a variation, you'll need to set its attributes (ie \"Color\", \"Size\") first.",
comment: "Subtitle on the variations list screen when there are no variations and attributes")
static let addAttributesAction = NSLocalizedString("Add Attributes",
comment: "Title on empty state button when the product has no attributes and variations")
Expand Down
24 changes: 0 additions & 24 deletions WooCommerce/Resources/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -1916,9 +1916,6 @@ which should be translated separately and considered part of this sentence. */
/* Message indicating no search result on the target location picker for campaign creation */
"blazeTargetLocationPickerViewModel.noResult" = "No location found.\nPlease try again.";

/* Hint message to enter search query on the target location picker for campaign creation */
"blazeTargetLocationPickerViewModel.searchViewHintMessage" = "Start typing country, state or city to see available options";

/* Title of the row to select all target location for Blaze campaign creation */
"blazeTargetLocationSearchView.allTitle" = "Everywhere";

Expand Down Expand Up @@ -2698,9 +2695,6 @@ which should be translated separately and considered part of this sentence. */
/* Country option for a site address. */
"Colombia" = "Colombia";

/* Message displayed if there are no inbox notes to display in the inbox screen. */
"Come back soon for more tips and insights on growing your store" = "Come back soon for more tips and insights on growing your store";

/* Country option for a site address. */
"Comoros" = "Comoros";

Expand Down Expand Up @@ -3383,9 +3377,6 @@ which should be translated separately and considered part of this sentence. */
/* Title when there are no customers in the search results in the Customers list screen. */
"customerList.emptySearchTitle" = "No customers found";

/* Message when there are no customers to show in the Customers list screen. */
"customerList.emptyStateMessage" = "Create an order to start gathering customer insights";

/* Title when there are no customers to show in the Customers list screen. */
"customerList.emptyStateTitle" = "No customers yet";

Expand Down Expand Up @@ -3476,9 +3467,6 @@ which should be translated separately and considered part of this sentence. */
/* Text for button that's shown when the list is empty. */
"customFieldsListHostingController.emptyStateButton" = "Learn more";

/* Message when the list is empty. */
"customFieldsListHostingController.emptyStateDescription" = "Custom fields are optional metadata to display extra information or customize your store's shopping experience";

/* Title for the message when the list is empty. */
"customFieldsListHostingController.emptyStateTitle" = "No custom fields found";

Expand Down Expand Up @@ -3606,9 +3594,6 @@ which should be translated separately and considered part of this sentence. */
/* Label of the button to share the store */
"dashboardView.shareStoreCard.shareButtonLabel" = "Share Your Store";

/* Subtitle of the Share Your Store card */
"dashboardView.shareStoreCard.subtitle" = "Use email or social media to spread the word about your store";

/* Title of the Share Your Store card */
"dashboardView.shareStoreCard.title" = "Get the word out!";

Expand Down Expand Up @@ -3977,9 +3962,6 @@ which should be translated separately and considered part of this sentence. */
/* Drag and drop helper text above photo list in Product images screen */
"Drag and drop to re-order photos" = "Drag and drop to re-order photos";

/* Subtitle of the empty state of the Blaze campaign list view */
"Drive more sales to your store with Blaze" = "Drive more sales to your store with Blaze";

/* Button title to duplicate a product in Product More Options Action Sheet */
"Duplicate" = "Duplicate";

Expand Down Expand Up @@ -4520,9 +4502,6 @@ which should be translated separately and considered part of this sentence. */
/* Button title to explore an extension that isn't installed */
"Explore" = "Explore";

/* The detailed message shown in the Orders → All Orders tab if the list is empty. */
"Explore how you can increase your store sales" = "Explore how you can increase your store sales";

/* Display label for affiliate product type. */
"External/Affiliate" = "External/Affiliate";

Expand Down Expand Up @@ -11332,9 +11311,6 @@ which should be translated separately and considered part of this sentence. */
/* Description text for the product discount row informational tooltip */
"To add a Product Discount, please remove all Coupons from your order" = "To add a Product Discount, please remove all Coupons from your order";

/* Subtitle on the variations list screen when there are no variations and attributes */
"To add a variation, you'll need to set its attributes (ie \"Color\", \"Size\") first" = "To add a variation, you'll need to set its attributes (ie \"Color\", \"Size\") first";

/* Error message displayed when unable to close user account due to having active atomic site. */
"To close this account now, contact our support team." = "To close this account now, contact our support team.";

Expand Down

0 comments on commit eb83f4f

Please sign in to comment.