[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 #14843

jaclync · 2025-01-10T05:40:15Z

Closes: #1483

Description

This pull request updates products and variations and filtering criteria based on the latest decision pdfdoF-62l-p2#comment-7224. It removes the virtual local filter (as we want to show virtual products), replaces the downloadable local filter with a parameter in the API request that works for WC versions 9.6+, and updates the page size from 100 to 25 for products and variations requests.

Regarding the page size, I tested with the smallest font size on the tallest iOS device available - iPad Pro 13 in' so far in iOS 18.2. The minimum amount of items to fill the scroll view in portrait is 10. Even so, I picked 25 to match Android. Please feel free to share any thoughts on the page size.

🗒️ It's likely we will update the minimum WC version requirement to 9.6 for POS based on p1736485809856869/1736484154.214279-slack-C070SJRA8DP. Since 9.6 is still in beta 2 at the time of writing, we will postpone the version requirement bump until the version is publicly released.

Pagination and Product Parameters:

Networking/Networking/Remote/ProductVariationsRemote.swift: Changed the variationsPerPage constant from 100 to 25.
Networking/Networking/Remote/ProductsRemote.swift: Added the downloadable parameter to the request and updated the productsPerPage constant from 100 to 25. [1] [2] [3]

Test Updates:

Networking/NetworkingTests/Remote/ProductsRemoteTests.swift: Added a new test to verify that the downloadable parameter is set correctly in the loadProductsForPointOfSale method.

Filtering Criteria:

Yosemite/Yosemite/PointOfSale/PointOfSaleItemService.swift: Removed the isNotVirtual and isNotDownloadable filtering functions and criteria. [1] [2]

Steps to reproduce

Switch to a store eligible for POS, has at least one variable and downloadable product, and has WC version >= 9.6
Go to Menu > Point of Sale mode --> the downloadable product should not be included, and all simple products in the list should have a price
Tap on a variable product --> variations should be loaded shortly, up to 25 per page

Testing information

@jaclync tests that the products are loaded without the downloadable filter for stores on WC version < 9.6

Screenshots

Notice that the downloadable products are filtered out.

before (with local filters removed)	after

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

…rtual` and `downloadable` API support.

…ment-7224.

wpmobilebot · 2025-01-10T05:51:06Z

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14843-614a7a1
	Version	21.4
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	`614a7a1`
	App Center Build	WooCommerce - Prototype Builds #12648

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

… to include virtual product in the API response.

staskus

This works as described. However, I think based on pdfdoF-62l-p2#comment-7285 it could be also expanded or done in another PR:

Allow no-price products
Restrict POS entry from 9.6+

staskus · 2025-01-10T18:49:52Z

Yosemite/Yosemite/PointOfSale/PointOfSaleItemService.swift

-    func isNotDownloadable(product: Product) -> Bool {
-        !product.downloadable
-    }
-
    func hasPrice(product: Product) -> Bool {


Based on pdfdoF-62l-p2#comment-7285, this one can be removed as well 👍

Removed in b192a0c.

jaclync · 2025-01-13T01:29:57Z

Potential latest decision: p1736504688523299/1736484154.214279-slack-C070SJRA8DP

Empty-price and free products should be shown in POS

Virtual products should be shown in POS

Let's limit it to version 9.6+, but we need to ensure that it won't get released unless WooCommerce 9.6 is publicly available

Based on the proposed decision above, I will wait for WC 9.6 to be released this week before making all the changes:

Remove empty price filter
Update minimum WC version to 9.6

jaclync · 2025-01-15T07:45:39Z

WC 9.6 is still not publicly available as of today. As I'm AFK after this Friday, I'm trying to get the PR ready for merge first and it can be merged when 9.6 is in GA.

@staskus it's not urgent, this PR is ready for review again with the changes in #14843 (comment).

jaclync · 2025-01-16T08:25:46Z

Unit tests are failing, please skip the review for now and I'll update when it's ready for review again.

staskus · 2025-01-16T09:35:44Z

Unit tests are failing, please skip the review for now and I'll update when it's ready for review again.

TTP education tests should hopefully succeed if you merge now with trunk.

…filter is removed.

jaclync · 2025-01-17T02:03:05Z

Ready for review now! A test case failing from the removal of the price filter was updated in 8916a21.

staskus

POS only available from 9.6
Downloadable filtered
No price products shown

We'll need to implement additional handling for these no price or zero price products to finish the order.

joshheald · 2025-01-20T17:16:06Z

@staskus thanks for the review; I think we're waiting to merge until we're sure 9.6 is released.

We'll need to implement additional handling for these no price or zero price products to finish the order.

We discussed this last week – I think all that's needed is:

Don't start a card payment if the order total is 0.
Ensure cash payments feature flag is enabled before variable products.

In future, we could optimise by adding a Mark order complete button on free orders, rather than requiring merchants to open the cash flow.

Context: p1736742009959369-slack-C070SJRA8DP

iamgabrielma · 2025-01-21T06:45:47Z

2. Ensure cash payments feature flag is enabled before variable products.

👀 Let me know if I'm holding this one by having the flag disabled, it can be enabled right away as soon as we merge this PR, as the rest it's just minor UI details.

To retain the ability to turn off the feature flag for variable products, we should only use the higher minimum WC version when the flag is enabled. If we disable the flag, downloadable products are still filtered out by local filters, and it’s no longer necessary to remove virtual products.

dangermattic · 2025-01-22T14:10:55Z

	1 Warning
⚠️	This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

jaclync added 5 commits January 10, 2025 13:04

Remove local virtual and downloadable filters in favor of WC 9.6+ `vi…

5232f80

…rtual` and `downloadable` API support.

Remove virtual parameter from the latest decision pdfdoF-62l-p2#com…

e576720

…ment-7224.

Update products/variations page size from 100 to 25 for POS.

f61ebe9

Nit: remove unused parameter.

3330c79

Add a test case for the POS products request parameters.

a93a79c

jaclync added type: task An internally driven task. feature: POS labels Jan 10, 2025

jaclync added this to the 21.5 milestone Jan 10, 2025

Remove downloadable from mock products API response. Update test case…

42be4bc

… to include virtual product in the API response.

jaclync marked this pull request as ready for review January 10, 2025 07:08

jaclync requested review from staskus, iamgabrielma and joshheald and removed request for iamgabrielma January 10, 2025 07:08

joshheald mentioned this pull request Jan 10, 2025

[Woo POS] Variation pagination #14849

Merged

4 tasks

staskus approved these changes Jan 10, 2025

View reviewed changes

jaclync added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 13, 2025

jaclync added 3 commits January 15, 2025 15:20

Merge branch 'trunk' into feat/14834-replace-local-filtering

0cef292

Remove local price filter.

b192a0c

Bump minimum WC version from 6.6 to 9.6.

96fce66

jaclync changed the title ~~[Woo POS] Replace product/variation local filtering with WC 9.6+ API support with page size 25~~ [Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter and page size 25 Jan 15, 2025

jaclync changed the title ~~[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter and page size 25~~ [Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 Jan 15, 2025

jaclync requested a review from staskus January 15, 2025 07:45

joshheald and others added 2 commits January 16, 2025 13:35

Merge branch 'trunk' into feat/14834-replace-local-filtering

f039cb2

Update test case to include product without price now that the price …

8916a21

…filter is removed.

jaclync removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 17, 2025

staskus approved these changes Jan 20, 2025

View reviewed changes

joshheald added 3 commits January 21, 2025 09:31

Merge branch 'trunk' into feat/14834-replace-local-filtering

5b977ca

Merge branch 'trunk' into feat/14834-replace-local-filtering

9334e3b

14834 Update minimum version to include betas

614a7a1

joshheald merged commit 561c13a into trunk Jan 23, 2025
12 checks passed

joshheald deleted the feat/14834-replace-local-filtering branch January 23, 2025 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 #14843

[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 #14843

jaclync commented Jan 10, 2025 •

edited by staskus

Loading

wpmobilebot commented Jan 10, 2025 •

edited

Loading

staskus left a comment

staskus Jan 10, 2025

jaclync Jan 15, 2025

jaclync commented Jan 13, 2025

jaclync commented Jan 15, 2025

jaclync commented Jan 16, 2025

staskus commented Jan 16, 2025

jaclync commented Jan 17, 2025

staskus left a comment

joshheald commented Jan 20, 2025

iamgabrielma commented Jan 21, 2025 •

edited

Loading

dangermattic commented Jan 22, 2025

[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 #14843

[Woo POS] Bump minimum required WC version to 9.6, replace local products filters with downloadable parameter, page size 25 #14843

Conversation

jaclync commented Jan 10, 2025 • edited by staskus Loading

Description

Pagination and Product Parameters:

Test Updates:

Filtering Criteria:

Steps to reproduce

Testing information

Screenshots

Reviewer (or Author, in the case of optional code reviews):

wpmobilebot commented Jan 10, 2025 • edited Loading

staskus left a comment

Choose a reason for hiding this comment

staskus Jan 10, 2025

Choose a reason for hiding this comment

jaclync Jan 15, 2025

Choose a reason for hiding this comment

jaclync commented Jan 13, 2025

jaclync commented Jan 15, 2025

jaclync commented Jan 16, 2025

staskus commented Jan 16, 2025

jaclync commented Jan 17, 2025

staskus left a comment

Choose a reason for hiding this comment

joshheald commented Jan 20, 2025

iamgabrielma commented Jan 21, 2025 • edited Loading

dangermattic commented Jan 22, 2025

jaclync commented Jan 10, 2025 •

edited by staskus

Loading

wpmobilebot commented Jan 10, 2025 •

edited

Loading

iamgabrielma commented Jan 21, 2025 •

edited

Loading