-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HACK Week: Add tracking for filter history #14844
Conversation
Generated by 🚫 Danger |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM and tracking works as expected. 🚀
Part of #14791
Description
This PR adds tracking for interactions with the filter history feature:
*_filter_history_button_tapped
source
:orders
orproducts
*_filter_history_past_filter_applied
source
:orders
orproducts
*_filter_history_past_filter_removed
source
:orders
orproducts
*_filter_history_cleared
source
:orders
orproducts
Steps to reproduce
filter_history_button_tapped
is tracked withsource
beingorders
.filter_history_past_filter_applied
is tracked withsource
beingorders
.filter_history_past_filter_removed
is tracked withsource
beingorders
.filter_history_cleared
is tracked withsource
beingorders
.Testing information
Tested with simulator iPhone 16 Pro iOS 18.1 and confirmed that the tracking works as expected.
Screenshots
N/A
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: