Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACK Week: Add tracking for filter history #14844

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 10, 2025

Part of #14791

Description

This PR adds tracking for interactions with the filter history feature:

Event name Trigger Properties
*_filter_history_button_tapped When the entry point is tapped source: orders or products
*_filter_history_past_filter_applied When a past filter is applied source: orders or products
*_filter_history_past_filter_removed When a past filter is removed source: orders or products
*_filter_history_cleared When the filter history is reset source: orders or products

Steps to reproduce

  • Log in to a test store with existing products and orders.
  • Navigate to the Orders tab and select Filter.
  • Tap the Clock icon, confirm that filter_history_button_tapped is tracked with source being orders.
  • If there is an existing filter in the history, select it and tap Apply. Confirm that filter_history_past_filter_applied is tracked with source being orders.
  • Navigate back to the filter history and remove an existing item. Confirm that filter_history_past_filter_removed is tracked with source being orders.
  • Tap Clear all history and confirm the selection. Confirm that filter_history_cleared is tracked with source being orders.
  • Repeat the above steps with the product list in the Products tab.

Testing information

Tested with simulator iPhone 16 Pro iOS 18.1 and confirmed that the tracking works as expected.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: enhancement A request for an enhancement. feature: order list Related to the order list. feature: product list Related to the product list. labels Jan 10, 2025
@itsmeichigo itsmeichigo added this to the 21.5 milestone Jan 10, 2025
@itsmeichigo itsmeichigo changed the base branch from trunk to hackweek/product-list-filter-history January 10, 2025 07:08
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 10, 2025

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14844-af9726d
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commitaf9726d
App Center BuildWooCommerce - Prototype Builds #12465
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo added the category: tracks Related to analytics, including Tracks Events. label Jan 10, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review January 10, 2025 07:34
@itsmeichigo itsmeichigo requested a review from pmusolino January 15, 2025 02:51
Base automatically changed from hackweek/product-list-filter-history to trunk January 15, 2025 11:52
@selanthiraiyan selanthiraiyan self-assigned this Jan 20, 2025
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM and tracking works as expected. 🚀

@itsmeichigo itsmeichigo merged commit 7d7d7a5 into trunk Jan 21, 2025
35 checks passed
@itsmeichigo itsmeichigo deleted the hackweek/14791-add-tracking branch January 21, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: order list Related to the order list. feature: product list Related to the product list. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants