-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping labels] Handle country and state selection for origin addresses #14867
Conversation
|
Good work @rachelmcr! It looks good to me. One minor thing, I noticed that in the Country/State selector we don't have any Cancel/Done button, but the user has to pull down the screen after selecting an item. I wonder if you consider adding buttons to make the selection more intuitive? ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just left a minor conmment regarding UI. 🚀 🚢
Good point. I had considered adding those nav buttons, but since we use the same view for editing addresses elsewhere (in an order) I decided to keep using it as-is for consistency. However, I see now that where it's used for order addresses the selection view is automatically popped when the selection is made. As far as I can tell that's not actually the intended behavior, and I'm not sure we want it in this context, but it does mean the user interaction is a bit different. After thinking it over, I decided to add a Done button here for ease of dismissing the view; that is updated in 9f0e01e. I'm not adding a Cancel button because the view changes the selection immediately, so adding a cancel action would require more involved updates to the view that I think are not worth the effort. Let me know if you have other thoughts/suggestions about that. :)
|
Part of: #13781
⚠️ Depends on #14866 ⚠️
Description
This adds support for selecting a country and state when editing an origin address in the Woo Shipping label flow.
Apologies for the slightly large PR; many of the lines of changes are from unit tests. I thought this was preferable to splitting the PR, given that it's hard to test the fetching behavior without the corresponding selection UI.
Updated behavior:
Testing information
Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-14.at.18.14.01.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: