Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sites: Update footer for other stores section #14901

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 17, 2025

Closes: #14900

Description

This PR updates the copy on the Visible Stores screen to include the detail about push notifications.

Steps to reproduce

  • Log in to an account connected to more than 1 store.
  • Navigate to the Menu tab > open the store picker > Edit.
  • Confirm that the footer text of the Other stores section now includes the detail about push notifications.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the copy is now correct.

Screenshots

Before After

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added the type: bug A confirmed bug. label Jan 17, 2025
@itsmeichigo itsmeichigo added this to the 21.4 ❄️ milestone Jan 17, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 17, 2025

1 Warning
⚠️ This PR is assigned to the milestone 21.4 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo changed the base branch from trunk to release/21.4 January 17, 2025 09:18
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14901-d65c3d0
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commitd65c3d0
App Center BuildWooCommerce - Prototype Builds #12576
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pmusolino pmusolino self-assigned this Jan 17, 2025
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@itsmeichigo itsmeichigo merged commit 4f57e3f into release/21.4 Jan 20, 2025
18 of 20 checks passed
@itsmeichigo itsmeichigo deleted the fix/14900-hiding-sites-copy branch January 20, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding sites: Copy update needed
4 participants