Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] [Variable Products] Update info banner to include variable products #14926

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 20, 2025

Closes: #14925

Description

This PR updates the "Simple Products Only" banner and modal to show that we also support variable products, and non-downloadable virtual products.

Steps to reproduce

Reinstall the app if you don't currently see the info banner at the top of the item list
Launch the app and go to POS
Observe that the banner and the modal it opens mention virtual products, not simple products only.

Change the feature flag variableProductsInPointOfSale to true

Repeat the above test but observe that the banner and modal have the previous text.

Testing information

Screenshots

Feature flag disabled

before.mp4

Feature flag enabled

after.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Jan 20, 2025
@joshheald joshheald added this to the 21.5 milestone Jan 20, 2025
@joshheald joshheald marked this pull request as ready for review January 20, 2025 16:48
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14926-6f4c134
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit6f4c134
App Center BuildWooCommerce - Prototype Builds #12606
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iamgabrielma iamgabrielma self-assigned this Jan 21, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@joshheald joshheald merged commit 339149e into trunk Jan 21, 2025
26 checks passed
@joshheald joshheald deleted the issue/14925-update-simple-products-banner branch January 21, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] [Variable Products] Update Simple Products modal to reflect support for variable products
3 participants