Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configuration Cache] Disable Configuration Cache on CI (V1) #21659

Closed
wants to merge 11 commits into from

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Feb 4, 2025

Related (Gradle 8.12.1 & AGP 8.8.1): #21690

Description

This change is primarily about disabling configuration cache (CC) on CI. But, before doing so, we should verify that disabling CC on CI is actually going improve build times, and if not.


To Test:

Testing on Gradle 8.8 and AGP 8.5.1 environment:

Job BT (With) BT (Without) BT (Diff) DR - Conf (With) DR - Exec (Without) DR (Diff) TE - Time [Factor] (With) TE - Time [Factor] (Without) TE (Diff)
Jetpack App 15m 1s 14m 41s -20s (✅) 2s 2s 0s (☑️) 11m 28s [2.03x] 11m 8s [1.73x] -20s (✅)
WordPress App 12m 53s 16m 32s +3m 39s (❌) 2s 3s +1s (❌) 9m 54s [2.02x] 12m 16s [1.75x] +2m 22s (❌)
Jetpack Lint 5m 22s 4m 47s -35s (✅) 2s 2s 0s (☑️) 2m 2s [6.22x 1m 55s [5.79x -7s (✅)
WordPress Lint 5m 55s 5m 20s -35s (❌) 3s 3s 0s (☑️) 2m 13s [6.06x 2m 4s [5.13x -9s (✅)
WordPress Unit Tests 5m 0s 5m 21s +21s (❌) 2s 2s 0s (☑️) 2m 2s [5.4x] 2m 14s [4.3x] +12s (❌)
Processors Unit Tests 2m 49s 3m 37s +48s (❌) 1s 1s 0s (☑️) 7s [1.43x] 10s [1.39x +3s (❌)
Image Editor Unit Tests 3m 13s 3m 27s +14s (❌) 1s 1s 0s (☑️) 12s [4.98x] 14s [4.11x] +2s (❌)
FluxC Unit Tests 3m 22s 3m 41s +19s (❌) 1s 1s 0s (☑️) 32s [3.18x] 38s [2.12x] +6s (❌)
Login Unit Tests 3m 35s 3m 39s +4s (❌) 1s 1s 0s (☑️) 31s [2.89x] 34s [2.61x] +3s (❌)

Note

  • Without: Without Configuration Cache
  • With: With Configuration Cache
  • BT: Build Time
  • DR: Dependency Resolution -
    • Conf: During configuration
    • Exec: During execution
  • TE: Task Execution
    • Time [Factor]: Time spent executing tasks [Serial execution factor]
Assemble (Jetpack) BT (With CC ) BT (Without CC) BT (Diff)
Without BC (Without DC) 17m 8s 14m 55s -2m 13s (✅)
Without BC (With DC) 17m 44s 15m 43s -2m 1s (✅)
With BC (Without DC) 7m 18s 6m 14s -1m 4s (✅)
With BC (With DC)1 4m 56s 5m 33s +37s (❌)

Note

  • CC: Configuration Cache
  • BC: Build Cache
  • DC: Dependency Cache

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To Test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

Footnotes

  1. You could also check this x10 build for some aggregate numbers. | (JP) BT (With CC ): 5m 8s | (JP) BT (Without CC ): 5m 18s | (WP) BT (With CC ): 13m 35s | (WP) BT (Without CC ): 13m 34s |

@ParaskP7 ParaskP7 added Core Tooling Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Feb 4, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 4, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21659-605e078
Commit605e078
Direct Downloadjetpack-prototype-build-pr21659-605e078.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 4, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21659-605e078
Commit605e078
Direct Downloadwordpress-prototype-build-pr21659-605e078.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.41%. Comparing base (d61a063) to head (605e078).

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21659      +/-   ##
==========================================
- Coverage   39.42%   39.41%   -0.01%     
==========================================
  Files        2122     2122              
  Lines       99558    99570      +12     
  Branches    15317    15324       +7     
==========================================
  Hits        39247    39247              
- Misses      56832    56844      +12     
  Partials     3479     3479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ParaskP7 ParaskP7 force-pushed the ci/disable-configuration-cache-on-ci branch from afff86c to e70bc17 Compare February 5, 2025 13:05
Copy link

sonarqubecloud bot commented Feb 6, 2025

@ParaskP7 ParaskP7 changed the title [Configuration Cache] Disable Configuration Cache on CI [Configuration Cache] Disable Configuration Cache on CI (V1) Feb 14, 2025
@ParaskP7 ParaskP7 changed the title [Configuration Cache] Disable Configuration Cache on CI (V1) [Configuration Cache] Disable Configuration Cache on CI (V1) Feb 18, 2025
@ParaskP7 ParaskP7 closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants