-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Configuration Cache] Disable Configuration Cache on CI (V1
)
#21659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21659-605e078 | |
Commit | 605e078 | |
Direct Download | jetpack-prototype-build-pr21659-605e078.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21659-605e078 | |
Commit | 605e078 | |
Direct Download | wordpress-prototype-build-pr21659-605e078.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21659 +/- ##
==========================================
- Coverage 39.42% 39.41% -0.01%
==========================================
Files 2122 2122
Lines 99558 99570 +12
Branches 15317 15324 +7
==========================================
Hits 39247 39247
- Misses 56832 56844 +12
Partials 3479 3479 ☔ View full report in Codecov by Sentry. |
afff86c
to
e70bc17
Compare
|
16 tasks
V1
)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Core
Do Not Merge
In PRs with this label, our automation will fail a require check, preventing accidental merging
Tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related (
Gradle 8.12.1
&AGP 8.8.1
): #21690Description
This change is primarily about disabling configuration cache (CC) on CI. But, before doing so, we should verify that disabling CC on CI is actually going improve build times, and if not.
To Test:
Testing on
Gradle 8.8
andAGP 8.5.1
environment:Factor
] (With)Factor
] (Without)-20s
(✅)0s
(☑️)2.03x
]1.73x
]-20s
(✅)+3m 39s
(❌)+1s
(❌)2.02x
]1.75x
]+2m 22s
(❌)-35s
(✅)0s
(☑️)6.22x
5.79x
-7s
(✅)-35s
(❌)0s
(☑️)6.06x
5.13x
-9s
(✅)+21s
(❌)0s
(☑️)5.4x
]4.3x
]+12s
(❌)+48s
(❌)0s
(☑️)1.43x
]1.39x
+3s
(❌)+14s
(❌)0s
(☑️)4.98x
]4.11x
]+2s
(❌)+19s
(❌)0s
(☑️)3.18x
]2.12x
]+6s
(❌)+4s
(❌)0s
(☑️)2.89x
]2.61x
]+3s
(❌)Note
Without
: Without Configuration CacheWith
: With Configuration CacheBT
: Build TimeDR
: Dependency Resolution -Conf
: During configurationExec
: During executionTE
: Task ExecutionTime [Factor]
: Time spent executing tasks [Serial execution factor]-2m 13s
(✅)-2m 1s
(✅)-1m 4s
(✅)+37s
(❌)Note
CC
: Configuration CacheBC
: Build CacheDC
: Dependency CacheRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To Test
section above.What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
N/A
Footnotes
You could also check this x10 build for some aggregate numbers. | (JP) BT (With CC ):
5m 8s
| (JP) BT (Without CC ):5m 18s
| (WP) BT (With CC ):13m 35s
| (WP) BT (Without CC ):13m 34s
| ↩