Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.6.1] Fix ClassCastException caused by assuming editorFragment was a Gutenb… #21666

Merged

Conversation

nbradbury
Copy link
Contributor

This PR includes the fix from #21665 but targets the release/25.6.1 branch.

…ergEditorFragment when it could be a GutenbergKitEditorFragment (for 25.6.1)
@nbradbury nbradbury requested a review from dcalhoun February 6, 2025 19:08
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 6, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@nbradbury nbradbury added the Gutenberg Editing and display of Gutenberg blocks. label Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 6, 2025

@nbradbury nbradbury marked this pull request as ready for review February 6, 2025 19:17
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The crash no occurs when building this branch to device. 🎉 Thank you!

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21666-350f043
Commit350f043
Direct Downloadwordpress-prototype-build-pr21666-350f043.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21666-350f043
Commit350f043
Direct Downloadjetpack-prototype-build-pr21666-350f043.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury merged commit e7fb43c into release/25.6.1 Feb 6, 2025
20 of 23 checks passed
@nbradbury nbradbury deleted the issue/21664-gutenberg-class-cast-exception-25.6.1 branch February 6, 2025 19:31
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.95%. Comparing base (ead73cb) to head (350f043).
Report is 1 commits behind head on release/25.6.1.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/25.6.1   #21666      +/-   ##
==================================================
+ Coverage           39.38%   39.95%   +0.57%     
==================================================
  Files                2123     1547     -576     
  Lines               99707    71584   -28123     
  Branches            15332    11691    -3641     
==================================================
- Hits                39265    28601   -10664     
+ Misses              56961    40505   -16456     
+ Partials             3481     2478    -1003     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants