-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[25.7] Fix ClassCastException caused by assuming editorFragment was a GutenbergEditorFragment #21667
[25.7] Fix ClassCastException caused by assuming editorFragment was a GutenbergEditorFragment #21667
Conversation
…ergEditorFragment when it could be a GutenbergKitEditorFragment (for 25.7)
Generated by 🚫 Danger |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The crash no occurs when building this branch to device. 🎉 Thank you!
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21667-7c459e0 | |
Commit | 7c459e0 | |
Direct Download | wordpress-prototype-build-pr21667-7c459e0.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21667-7c459e0 | |
Commit | 7c459e0 | |
Direct Download | jetpack-prototype-build-pr21667-7c459e0.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/25.7 #21667 +/- ##
================================================
+ Coverage 39.29% 40.00% +0.71%
================================================
Files 2113 1546 -567
Lines 99208 71442 -27766
Branches 15279 11676 -3603
================================================
- Hits 38980 28583 -10397
+ Misses 56763 40383 -16380
+ Partials 3465 2476 -989 ☔ View full report in Codecov by Sentry. |
This PR includes the fix from #21665 but targets the
release/25.7
branch.