Fix site creation illegal state

[nbradbury]

Potentially fixes #21669

This was initially addressed in #21566 but we continue to see the crash even in 25.6, albeit less frequently.

I was not able to reproduce the crash in trunk but looking at the site creation code I noticed we were forcing the keyboard to appear with every single key press while searching. This could easily cause problems, especially if the runnable we used to delay the showing of the keyboard executed when the screen was no longer active.

To resolve this I chose to simply remove the force showing of the keyboard, instead letting the system handle it when the user taps the search field. I did note the following comment above the old code that forced the keyboard to show:

/**
 * This workaround handles the case where the SiteCreationDomainsFragment appears after the
 * DesignPreviewFragment dismisses and the keyboard fails to appear
 */

This is still an issue, but the keyboard will appear when the user taps the search field, and I think that's better than constantly forcing the keyboard to unnecessarily appear.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21670-39d4316
	Commit	39d4316
	Direct Download	jetpack-prototype-build-pr21670-39d4316.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21670-39d4316
	Commit	39d4316
	Direct Download	wordpress-prototype-build-pr21670-39d4316.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.38%. Comparing base (32501d0) to head (39d4316).
Report is 1 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #21670      +/-   ##
==========================================
- Coverage   39.42%   38.38%   -1.04%     
==========================================
  Files        2122      601    -1521     
  Lines       99558    28992   -70566     
  Branches    15317     3732   -11585     
==========================================
- Hits        39247    11128   -28119     
+ Misses      56832    16847   -39985     
+ Partials     3479     1017    -2462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dcalhoun]

Changes tested well for me.

To resolve this I chose to simply remove the force showing of the keyboard, instead letting the system handle it when the user taps the search field. I did note the following comment above the old code that forced the keyboard to show:

This seems like a reasonable trade-off to me.

For posterity, it appears this workaround was added in #13424 (comment); the original keyboard display was added in #12085.