Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Discover not matching iOS & Web #21707

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Feb 24, 2025

Fixes #21706

The "Discover" stream in the Android reader shows different content than the iOS and web readers. There were two primary reasons for this:

  • The Discover stream showed an empty view when the user wasn't following any tags
  • We should request the dailyprompt and wordpress tags to match the other readers when there are no followed tags

To test, I recommend removing all tags in the web reader, then verifying the Android reader shows roughly the same content. Next, add some tags and verify the readers show similar content.

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 24, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 24, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21707-6f3106d
Commit6f3106d
Direct Downloadwordpress-prototype-build-pr21707-6f3106d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 24, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21707-6f3106d
Commit6f3106d
Direct Downloadjetpack-prototype-build-pr21707-6f3106d.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.41%. Comparing base (dbf22f7) to head (6f3106d).
Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
...ui/reader/services/discover/ReaderDiscoverLogic.kt 0.00% 4 Missing ⚠️
...roid/ui/reader/discover/ReaderDiscoverViewModel.kt 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21707   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files        2122     2122           
  Lines       99570    99570           
  Branches    15324    15324           
=======================================
  Hits        39247    39247           
  Misses      56844    56844           
  Partials     3479     3479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury requested review from kean and dcalhoun February 25, 2025 12:51
@nbradbury nbradbury marked this pull request as ready for review February 25, 2025 12:52
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing plan succeeded for me.

I noted one issue occurring on trunk that appears unrelated to these changes: None of the WordPress.com News post featured images loaded in the Android app. Featured images from other sites—e.g., The Atavist Magazine—do load.

Missing images screenshot

WordPress.com News site missing featured images

@nbradbury nbradbury merged commit fe06d91 into trunk Feb 25, 2025
23 checks passed
@nbradbury nbradbury deleted the issue/21706-reader-discover-no-tags branch February 25, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Reader Discover not matching iOS & Web
4 participants