Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer throw when false-negative result setting same value #22

Open
wants to merge 3 commits into
base: 0.2.x
Choose a base branch
from
Open

No longer throw when false-negative result setting same value #22

wants to merge 3 commits into from

Conversation

XedinUnknown
Copy link
Member

This addresses #17 by, in the scenario where setting a transient fails, checking if the existing value is the same as new one before throwing.

@XedinUnknown XedinUnknown added the bug Something isn't working label Oct 13, 2023
@XedinUnknown XedinUnknown added this to the v0.2 milestone Oct 13, 2023
@XedinUnknown XedinUnknown requested a review from mecha October 13, 2023 10:08
@XedinUnknown XedinUnknown self-assigned this Oct 13, 2023
mecha
mecha approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@mecha mecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mecha mecha mecha approved these changes

Assignees

@XedinUnknown XedinUnknown

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@XedinUnknown @mecha