[cmd] Add a warning to schedule javadocs
#7073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Sep 13, 2024
|
The preferred design pattern should be explained, not just a warning about use. |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
7cf1e9c to
b427b2e
Compare
|
/format |
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Sep 13, 2024
calcmogul
changed the title
schedule javadocsschedule javadocs
|
I think you can use @warning for the c++ |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
d003a37 to
6eb9b24
Compare
|
/format |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
6eb9b24 to
32a9c22
Compare
|
/format |
|
@sciencewhiz can you review? |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
16c19f5 to
2a1178c
Compare
|
/format |
Starlight220
reviewed
Nov 4, 2024
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
schedule-warning
branch
from
46f9b37 to
2613107
Compare
PeterJohnson
requested changes
Dec 15, 2024
|
/format |
github-actions
bot
added
the
component: command-based
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/CommandScheduler.java
Outdated
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
schedule-warning
branch
from
87b450a to
4d5cc46
Compare
|
/format |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
2cd4e88 to
879a5fe
Compare
|
/format |
PeterJohnson
approved these changes
Jan 2, 2025
rzblue
approved these changes
Jan 2, 2025
Starlight220
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.