Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntcore] Various cleanups #7216

Merged
merged 8 commits into from
Nov 8, 2024
Merged

[ntcore] Various cleanups #7216

merged 8 commits into from
Nov 8, 2024

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson commented Oct 16, 2024 •
edited
Loading

TODO:

  • Eliminate ServerImpl friends (circular dependencies)
  • Refactor ServerImpl.AddClient / AddClient3 to remove direct dependency on ServerClient3 and ServerClient4

@PeterJohnson PeterJohnson force-pushed the nt-server-cleanup branch 2 times, most recently from 9c29645 to 207df78 Compare October 22, 2024 02:15
@PeterJohnson PeterJohnson marked this pull request as ready for review October 22, 2024 02:15
@PeterJohnson PeterJohnson requested a review from a team as a code owner October 22, 2024 02:15
KangarooKoala
KangarooKoala reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might've missed some things, but I think I checked everything.

ntcore/src/main/native/cpp/LocalStorage.h Show resolved Hide resolved
ntcore/src/main/native/cpp/local/LocalStorageImpl.cpp Show resolved Hide resolved
ntcore/src/main/native/cpp/local/LocalStorageImpl.cpp Show resolved Hide resolved
ntcore/src/main/native/cpp/local/LocalTopic.cpp Show resolved Hide resolved
ntcore/src/main/native/cpp/LocalStorage.h Outdated Show resolved Hide resolved
ntcore/src/main/native/cpp/local/LocalStorageImpl.cpp Show resolved Hide resolved
@PeterJohnson PeterJohnson merged commit 01f85ab into wpilibsuite:main Nov 8, 2024
42 checks passed
@PeterJohnson PeterJohnson deleted the nt-server-cleanup branch November 8, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

Assignees
No one assigned
Labels
None yet
Projects
NetworkTables
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterJohnson @KangarooKoala