Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java unit support for RobotController #7278

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Add Java unit support for RobotController #7278

merged 4 commits into from
Oct 28, 2024

Conversation

Braykoff
Copy link
Contributor

Resolves #7186

@Braykoff Braykoff requested a review from a team as a code owner October 23, 2024 03:18
@Braykoff
Copy link
Contributor Author

/format

PeterJohnson
PeterJohnson reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@PeterJohnson PeterJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use MutMeasures so it's not allocating a new object on every call.

@Braykoff
Copy link
Contributor Author

@PeterJohnson Are you thinking of preallocating a separate MutMeasure for each method, then mut_replacing and returning it on each call?

@PeterJohnson
Copy link
Member

Yes exactly.

@PeterJohnson PeterJohnson merged commit 6207992 into wpilibsuite:main Oct 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Java unit support for RobotController
2 participants
@Braykoff @PeterJohnson