-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Make Gradle doxygen build use CMake #7290
[build] Make Gradle doxygen build use CMake #7290
Conversation
spacey-sooty
commented
Oct 25, 2024
•
edited
Loading
edited
- Unblocks [build] Update Gradle to 8.10.2 #7164
- Requires [build] CMake: Make Protobuf dependency actually optional #7291
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Matches wpilibsuite/GradleRIO#748 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
1d8dcc8
to
8de2e74
Compare
If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged. |
I don't think I like having one build system depend on another build system |
I'd rather generate a Doxyfile from the template we already have and invoke doxygen directly from gradle |
The 10.8.2 build was failing because of the plugin we use to generate Doxygen docs. This PR removes that |
I understand how this unblocks the other PR- What I'm saying is that when this gets merged, the PR shouldn't include the work of the other PR. |
Oh yes I fully didn't realise I'd put that there mb 😅 |
All good! At least it gives us a better idea of if there are other issues that'll need solving. |
OBE with Gradle doxygen releasing new update |