Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Make Gradle doxygen build use CMake #7290

Closed

Conversation

spacey-sooty
Copy link
Contributor

@spacey-sooty spacey-sooty commented Oct 25, 2024

@spacey-sooty spacey-sooty changed the title [build] CMake: add Doxygen doc generation [build] Make Gradle doxygen build use CMake Oct 25, 2024
Gold856 and others added 8 commits October 25, 2024 23:23
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Matches wpilibsuite/GradleRIO#748

Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
@spacey-sooty spacey-sooty force-pushed the build-cpp-docs-from-cmake branch from 1d8dcc8 to 8de2e74 Compare October 25, 2024 15:23
@KangarooKoala
Copy link
Contributor

If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged.

@sciencewhiz
Copy link
Contributor

I don't think I like having one build system depend on another build system

@rzblue
Copy link
Member

rzblue commented Oct 25, 2024

I'd rather generate a Doxyfile from the template we already have and invoke doxygen directly from gradle

@spacey-sooty
Copy link
Contributor Author

If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged.

The 10.8.2 build was failing because of the plugin we use to generate Doxygen docs. This PR removes that

@KangarooKoala
Copy link
Contributor

If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged.

The 10.8.2 build was failing because of the plugin we use to generate Doxygen docs. This PR removes that

I understand how this unblocks the other PR- What I'm saying is that when this gets merged, the PR shouldn't include the work of the other PR.

@spacey-sooty
Copy link
Contributor Author

If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged.

The 10.8.2 build was failing because of the plugin we use to generate Doxygen docs. This PR removes that

I understand how this unblocks the other PR- What I'm saying is that when this gets merged, the PR shouldn't include the work of the other PR.

Oh yes I fully didn't realise I'd put that there mb 😅

@KangarooKoala
Copy link
Contributor

If this unblocks #7164, shouldn't the update to 10.8.2 be done in that PR? (And not this one) If you just want to make sure that the 10.8.2 build would work, then that's fine, just remember to revert it before this gets merged.

The 10.8.2 build was failing because of the plugin we use to generate Doxygen docs. This PR removes that

I understand how this unblocks the other PR- What I'm saying is that when this gets merged, the PR shouldn't include the work of the other PR.

Oh yes I fully didn't realise I'd put that there mb 😅

All good! At least it gives us a better idea of if there are other issues that'll need solving.
(Also wow, that's a lot of nested replies)

@spacey-sooty
Copy link
Contributor Author

OBE with Gradle doxygen releasing new update

@spacey-sooty spacey-sooty deleted the build-cpp-docs-from-cmake branch October 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants