[wpilib] Remove LiveWindow #7733
Conversation
This will be replaced by a different mechanism, but removing it eases the initial implementation burden of a new Telemetry/Sendable framework.
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
github-actions
bot
added
component: wpiutil
| org.gradle.jvmargs=-Xmx2g | ||
| org.gradle.jvmargs=-Xmx4g |
There was a problem hiding this comment.
Out of curiosity, why was this change made in this PR? (I wouldn't be surprised if making this change is fitting for the new MRC, but I'm not sure how this change relates to removing LiveWindow)
There was a problem hiding this comment.
Accidentally committed because I had to make the change locally to successfully build with Gradle. Given we no longer have 32-bit builds I think this is safe to leave?
There was a problem hiding this comment.
Yeah, this change is probably fine (especially since it's for 2027 with new MRC, though apparently the RFP only requires 3GB of RAM available to user code)- I was just wondering if there was a connection to removing LW that I was missing.
There was a problem hiding this comment.
The MRC has 4 gb of RAM. https://community.firstinspires.org/introducing-the-future-mobile-robot-controller
But that setting is irrelevant for the MRC or the roborio, it's for the computer building allwpilib. Even with on robot development, I don't think that extends to building allwpilib.
There was a problem hiding this comment.
Yes, the entire MRC has 4 GB of RAM, but per MRC20 in the RFP, only 3 GB needs to be available to user code (since other programs running on the MRC would take up some memory).
Regardless, you're right that the settings are only for building allwpilib with Gradle, which would not be done on the MRC, so this discussion is moot. (The conservation is good to be resolved)
This will be replaced by a different mechanism, but removing it eases the initial implementation burden of a new Telemetry/Sendable framework.