-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hal] Change usage reporting to string-based #7763
[hal] Change usage reporting to string-based #7763
Conversation
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
Fixes #301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a mix of adding one to the port and not adding one to the port? (Notably, AnalogAccerelometer and DigitalInput have different behavior depending on the language)
Files that started adding one: None
Files that still add one: hid.lang.jinja
, pwm_motor_controller.lang.jinja
, AnalogAccelerometer.cpp
, DigitalInput.cpp
Files that never added one: ADXL345_I2C.java
(didn't report port before), I2C.lang
(used to report just device address, now also reports port), PowerDistribution.lang
(didn't port module before), UpDownCounter.java
Files that no longer add one: AddressableLED.lang
, AnalogAccelerometer.java
, AnalogGyro.java
, CAN.lang
, Compressor.lang
, DigitalInput.java
, DigitalOutput.lang
, DoubleSolenoid.lang
, DutyCycle.lang
, Encoder.lang
(part of changing from using FPGA index to using a and b channels), Joystick.lang
, PWM.lang
, SerialPort.lang
, Servo.lang
, Solenoid.lang
, Tachometer.lang
, UpDownCounter.cpp
, NidecBrushless.lang
wpilibj/src/main/java/edu/wpi/first/wpilibj/motorcontrol/NidecBrushless.java
Outdated
Show resolved
Hide resolved
We shouldn't be adding 1 anywhere; I'll fix the remaining instances (I realized I needed to fix that partway through doing these updates which is why some were missed). They should have always added 1 in the "old" implementation because 0 had a special meaning in the old implementation. |
306513e
to
0a53693
Compare
TODO:
std::to_string
/String.valueOf
is easy)Fixes #301.