-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2024 files #6
Conversation
Why is Phoenix6 using "frcjson"? |
I think the answer should come from @JCaporuscio but my understanding is that because we want a different json file for each version that his is how those are automatically generated. I don't think that has to be the case for the future but it may be? The only real requirement that we have is that the name cannot clash per year with another "vendor". Keep in mind that this is not the actual name that the user sees. That is specified in the file (fileName key) in this case "Phoenix6.json" |
That file naming is how our vendordeps are internally generated and archived, so to grab multiple specific versions all at once it's (currently) the only option. In the case where we add each json version as we go (say, a PR each time we release) the naming would match the current public-facing naming (ie Phoenix6-[version].json). For an initial batch add like this, since there's only half a dozen files or so I would highly recommend renaming them to match the public-facing naming to avoid future confusion. So "Phoenix6-[version].json" or "Phoenix5-[version]".json depending on which lib it is. |
No description provided.