-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move saml idp settings form impl. to final form #7319
base: master
Are you sure you want to change the base?
[WIP] Move saml idp settings form impl. to final form #7319
Conversation
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the side-by-side comparison of the old implementation and new implementation during development. This change will be reverted once the migration is completed.
]; | ||
}; | ||
|
||
const authenticationContextClassOptions: DropdownChild[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check whether there is a way to get the available authentication context class options from a backend API.
cc: @NipuniBhagya
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7319 +/- ##
=======================================
Coverage 36.04% 36.04%
=======================================
Files 42 42
Lines 899 899
Branches 205 222 +17
=======================================
Hits 324 324
+ Misses 575 529 -46
- Partials 0 46 +46
Flags with carried forward coverage won't be shown. Click here to find out more. |
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks