-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Custom Authenticator Settings Page #7499
Merged
ashanthamara
merged 31 commits into
wso2:master
from
Shenali-SJ:custom-auth-edit-settings
Feb 7, 2025
Merged
Refactor Custom Authenticator Settings Page #7499
ashanthamara
merged 31 commits into
wso2:master
from
Shenali-SJ:custom-auth-edit-settings
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7499 +/- ##
=======================================
Coverage 41.77% 41.77%
=======================================
Files 42 42
Lines 936 936
Branches 227 235 +8
=======================================
Hits 391 391
Misses 501 501
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. |
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/connection-edit.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 4, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
ashanthamara
reviewed
Feb 6, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Outdated
Show resolved
Hide resolved
18b5d41
to
cb1b820
Compare
ashanthamara
reviewed
Feb 6, 2025
ashanthamara
reviewed
Feb 6, 2025
ashanthamara
reviewed
Feb 6, 2025
ashanthamara
reviewed
Feb 6, 2025
…custom-auth-edit-settings
NipuniBhagya
reviewed
Feb 7, 2025
features/admin.connections.v1/components/create/custom-authentication-create-wizard.tsx
Outdated
Show resolved
Hide resolved
NipuniBhagya
previously approved these changes
Feb 7, 2025
features/admin.connections.v1/components/edit/settings/custom-authenticator-settings.tsx
Show resolved
Hide resolved
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
ashanthamara
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactors the custom authenticator settings page by extracting the code to a new react component. It also utilizes form spy to handle validations.
settings.mov
Related Issues
Related PRs
Checklist
Security checks