Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ValueError for missing grid_mapping variable #458

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

larsbuntemeyer
Copy link
Contributor

closes #448

This implements the fix suggested by @dcherian in #448

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #458 (0d44411) into main (e283a83) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   86.33%   86.34%           
=======================================
  Files          22       22           
  Lines        4180     4188    +8     
  Branches      214      214           
=======================================
+ Hits         3609     3616    +7     
- Misses        513      514    +1     
  Partials       58       58           
Flag Coverage Δ
mypy 37.44% <0.00%> (-0.08%) ⬇️
unittests 95.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/tests/test_accessor.py 94.11% <83.33%> (-0.06%) ⬇️
cf_xarray/accessor.py 86.47% <100.00%> (+0.02%) ⬆️

@larsbuntemeyer larsbuntemeyer changed the title added ValueError for missing grid_mapping variable added ValueError for missing grid_mapping variable Jul 12, 2023
@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review July 12, 2023 17:36
@dcherian
Copy link
Contributor

Thanks @larsbuntemeyer

@dcherian dcherian merged commit af8475a into xarray-contrib:main Jul 12, 2023
@larsbuntemeyer larsbuntemeyer deleted the mapping-fix branch July 12, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid mappings not propagated causes accessor failures
2 participants