Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kvikio backend entrypoint #10
Add Kvikio backend entrypoint #10
Changes from all commits
9deadb7
aa2dc91
7fb4b94
743fe7d
5d501e4
facf5f7
f3f5189
9c98d19
dd8bc57
d2da1e4
b87c3c2
87cb74e
d7394ef
1b23fef
ca0cf45
97260d6
5d27b26
85491d7
c470b97
95efa18
d684dad
ae2a7f1
15fbafd
f3df115
4e1857a
7345b61
e2b410e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently stuck on this line, and trying to figure out what to change in relation to pydata/xarray#6874. My guess is that in an ideal world where we've solved all the numpy/cupy duck typing issues, we could just use the recently modified
ZarrArrayWrapper
(pydata/xarray#8472) like this:However, that leads to this error:
Looked into this a bit and got lost in all the xarray class inheritance logic and mixins... @dcherian, could you point out what's the recommended route forward? Is there something we still need to upstream into xarray? I'm testing this on
xarray=2024.6.0
btw.Output of
xr.show_versions()
for reference:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also facing a problem at the same place in the code when it comes to dimension coordinates. Consider the dummy dataset:
that I write to a zarr file:
which is ok to read back with:
But when I want to use the
kvikio
engine:it fails with:
Any idea?
Just a bit of context: I'm working on a large radio astronomy project called RADIOBLOCKS where I'm willing to process very large Dask Xarray Datasets on a GPU cluster, hence my interest for your work on
kvikio
. Our GPU cluster has H100 and GDS if that is of interest for you for running benchmarks.Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core issue here is that the "eager" wrapper isn't working as expected. Dimension coordinates must be eagerly loaded in to CPU memory, and this is a bit hacky at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiji14 I think pydata/xarray#8408 fixes your issue. It needs a test though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried @dcherian's suggestion, with
but now it fails with:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orliac What xarray version do you use?
I think this might be a relevant to this PR:
pydata/xarray#8845
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed with this introduction by @andersy005
https://github.com/andersy005/xarray/blob/c4547d3c6a582567200ba85a373fc7ba3c25eedf/xarray/core/indexing.py#L984C1-L991C34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @negin513
I had this version installed:
xarray 2024.7.1.dev57+g25debff9.d20240911