Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic pluggable cache mechanism #167

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Feb 4, 2023

Description of proposed changes

New PR to continue the prototype that Joe Hamman started at #115.

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #167 (c5e3ba0) into main (ebd4354) will increase coverage by 0.20%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   96.04%   96.25%   +0.20%     
==========================================
  Files           6        6              
  Lines         329      347      +18     
  Branches       78       82       +4     
==========================================
+ Hits          316      334      +18     
  Misses          8        8              
  Partials        5        5              
Files Changed Coverage Δ
xbatcher/generators.py 95.18% <100.00%> (+0.51%) ⬆️

@maxrjones maxrjones changed the title WIP: Basic pluggable cache mechanism Basic pluggable cache mechanism Jul 31, 2023
@maxrjones maxrjones requested a review from norlandrhagen July 31, 2023 22:21
Copy link
Contributor

@norlandrhagen norlandrhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the failing codecov CI expected? Other than that, looks good to me!

@maxrjones
Copy link
Member Author

Is the failing codecov CI expected?

Thanks for catching that! It related to a missing dependency - fixed now

@maxrjones maxrjones merged commit f9d7ac8 into xarray-contrib:main Jul 31, 2023
@maxrjones maxrjones deleted the pluggable-cache branch July 31, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants