Add Windows Secure Boot key upgrade tests #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Also make sure that the cloned VMs are deleted after testing. Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Separate a variable's owner key and non-owner certs. This allows creating Secure Boot variables with multiple certificates inside. Also make self-signed cert/key initialization explicit. Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
We're now shipping more Secure Boot variables with varstored. As such, the following tests have changed: - test_start_vm_without_uefi_vars_on_pool_with_only_pk: No longer applicable. - test_clear_custom_pool_certificates: Only check for symlink when clearing certs, as the condition that hosts only have PK after `secureboot-certs clear` is no longer true. Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Signed-off-by: Tu Dinh <ngoc-tu.dinh@vates.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're including more Secure Boot keys by default in varstored, add tests for upgrading guest keys from the old defaults to the new ones, using certificates provided by microsoft/secureboot_objects. Additionally, disable tests that aren't applicable any more with the variable changes.
Since the new SB variables each include multiple certificates, refactor the Certificate and EFIAuth classes to support them.
Finally, add some tweaks for running tests with VM UUIDs.