Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-48198: docs-only: test_filter_xapi_clusterd_db.py: Clean-up of comment in header #102

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Mar 28, 2024

Only clean-up of comments:

tests/unit/test_filter_xapi_clusterd_db.py (no code change, not even test code):

Clean-up too long comments in tests/unit/test_filter_xapi_clusterd_db.py:

…mit.md now

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #102 (f3bc339) into master (d0e569d) will increase coverage by 10%.
Report is 19 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #102     +/-   ##
=======================================
+ Coverage      88%    98%    +10%     
=======================================
  Files          18     18             
  Lines        2196    665   -1531     
=======================================
- Hits         1939    654   -1285     
+ Misses        257     11    -246     
Files Coverage Δ
tests/unit/test_filter_xapi_clusterd_db.py 100% <ø> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
python2.7 96% <ø> (+9%) ⬆️
python3.10.13 ?
python3.10.14 100% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8473778451

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.084%

Totals Coverage Status
Change from base Build 8433749145: 0.0%
Covered Lines: 677
Relevant Lines: 712

💛 - Coveralls

@bernhardkaindl bernhardkaindl changed the title test_filter_xapi_clusterd_db.py: Cleanup docs that are in doc/pre-commit.md now CP-48198: test_filter_xapi_clusterd_db.py: Cleanup docs that are in doc/pre-commit.md now Mar 29, 2024
@bernhardkaindl bernhardkaindl changed the title CP-48198: test_filter_xapi_clusterd_db.py: Cleanup docs that are in doc/pre-commit.md now CP-48198: docs-only: test_filter_xapi_clusterd_db.py: Clean-up of comment in header Mar 30, 2024
@bernhardkaindl bernhardkaindl merged commit db222e5 into xenserver:master Apr 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docstring/Comment cleanup documentation only Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants