Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-48198: .codecov.yml: Fix Py3 coverage flag used to python3.10 #106

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Mar 29, 2024

Based on #197:

Commit 1 is already merged from #107 (it fixes coverage upload from master and labels Python3 coverage upload to python3.10)

That means only this commit is left to review: 377c762 - Commit 2:

  • .codecov.yml: Likewise, change the Python3 coverage flag used here to python3.10.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Merging #106 (377c762) into master (d0e569d) will increase coverage by 2.9%.
Report is 19 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #106     +/-   ##
========================================
+ Coverage    88.2%   91.2%   +2.9%     
========================================
  Files          18      18             
  Lines        2196    2228     +32     
========================================
+ Hits         1939    2034     +95     
+ Misses        257     194     -63     

see 2 files with indirect coverage changes

Flag Coverage Δ
python2.7 96.6% <ø> (+9.7%) ⬆️
python3.10 91.1% <ø> (?)
python3.10.13 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 8487827419

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.426%

Totals Coverage Status
Change from base Build 8474976295: 0.0%
Covered Lines: 2059
Relevant Lines: 2277

💛 - Coveralls

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the CP-48198/update-codecov.yml-for-3.10.14 branch from 6656f29 to 377c762 Compare March 30, 2024 02:38
@bernhardkaindl bernhardkaindl changed the title CP-48198: .codecov.yml: Update config for Python 3.10.14 in GitHub runners CP-48198: .codecov.yml (GitHub CI): Use python3.10 as flag, not 3.10.13, etc Mar 30, 2024
@bernhardkaindl bernhardkaindl changed the title CP-48198: .codecov.yml (GitHub CI): Use python3.10 as flag, not 3.10.13, etc CP-48198: .codecov.yml: Fix the Python3 coverage flag used to python3.10 Mar 30, 2024
@bernhardkaindl bernhardkaindl changed the title CP-48198: .codecov.yml: Fix the Python3 coverage flag used to python3.10 CP-48198: .codecov.yml: Fix Py3 coverage flag used to python3.10 Mar 30, 2024
@bernhardkaindl bernhardkaindl requested a review from GeraldEV April 2, 2024 08:41
@bernhardkaindl bernhardkaindl merged commit f87b510 into xenserver:master Apr 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants