Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace types from once_cell with std::sync::OnceLock #3345

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

FreezyLemon
Copy link
Contributor

std::sync::OnceLock is effectively the same as once_cell::sync::OnceCell, and because the MSRV is now 1.70 it can be used instead. Lazy<T> can also simply be replaced by a OnceLock, making the once_cell dependency unnecessary.

@FreezyLemon FreezyLemon changed the title Replace types from once_cell with std alternatives Replace types from once_cell with std::sync::OnceLock Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7155fe3) 88.54% compared to head (f9a67b5) 88.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   88.54%   88.52%   -0.02%     
==========================================
  Files          89       89              
  Lines       28334    28323      -11     
==========================================
- Hits        25087    25074      -13     
- Misses       3247     3249       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shssoichiro shssoichiro merged commit 3c3a26f into xiph:master Jan 28, 2024
24 of 25 checks passed
@FreezyLemon FreezyLemon deleted the remove-once-cell-dep branch January 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants