Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: add lookup interface to getIP #56

Merged
merged 1 commit into from
Jul 7, 2024
Merged

RF: add lookup interface to getIP #56

merged 1 commit into from
Jul 7, 2024

Conversation

syywu
Copy link
Contributor

@syywu syywu commented Jun 27, 2024

  • Refactored to utilise the LookUp interface implemented in checks/client/ip
  • Fixed error handling where error is only returned if both IPV4 and IPV6 addresses are not present

@syywu
rf: add lookup interface to getIP
1465a81 
fix: only error when both ipv4 and ipv6 are empty
@syywu syywu requested a review from Lissy93 as a code owner June 27, 2024 22:34
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 60.75% <62.50%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
checks/checks.go 0.00% <0.00%> (ø)
checks/getIP.go 78.57% <80.00%> (+52.48%) ⬆️
handlers/getIP.go 54.54% <50.00%> (ø)

@kynrai kynrai merged commit 9e2207a into xray-web:main Jul 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kynrai kynrai kynrai approved these changes

@Lissy93 Lissy93 Awaiting requested review from Lissy93 Lissy93 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syywu @kynrai