Using a Moose Role for FFI #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[The MooseX::Role::FFI is provided here to make the review of both easier to do at the same time. It will be released separately if we were to approve this PR.] The MooseX::Role::FFI allows to specify the subroutine data and the library name - as well as the fallback - as subroutines. It will then generate the corresponding callback for each sub, which can be reached via a method. The `after` allows us to have direct access to the FFI object *before* the callbacks are generated. (Which I think is when we need it for the mangler to work, but I'm not sure.) What I like about it: * Metadata, the rest is generated. * Alien support built-in. * We don't need to have class-level variables (though we could change it to it instead of subroutines.) * We don't need to check that it has been instantiated (like we do in _get_version and $HAS_SUBS) What I don't like about it: * We need to make another method call to get the callback, depsite it being a definition of the class, not the instance. * If you have a typo in the callback name, you cannot catch it, because it's a string to retrieve it. I'm not sure the benefits outweigh the drawbacks. I was thinking of possibly providing *another* interface and saying "pick yours."
plicease
reviewed
Aug 2, 2019
plicease
reviewed
Aug 2, 2019
| @@ -3,7 +3,7 @@ use warnings; | |||
| use Test::More; | |||
| use Audio::Chromaprint; | |||
|
|
|||
| note "version = ", Audio::Chromaprint->get_version; | |||
| note "version = ", Audio::Chromaprint->new->get_version; | |||
plicease
reviewed
Aug 2, 2019
| or croak('Unable to get raw fingerprint (get_raw_fingerprint)'); | ||
|
|
||
| # not espeically fast, but need a cast with a variable length array | ||
| my $fp = FFI::Platypus->new->cast( 'opaque' => "uint32[$size]", $ptr ); | ||
| _dealloc($ptr); | ||
| my $fp = $self->ffi->cast( 'opaque' => "uint32[$size]", $ptr ); |
plicease
reviewed
Aug 2, 2019
|
|
||
| return _get_version(); | ||
| around '_build_ffi' => sub { |
There was a problem hiding this comment.
maybe we can do this with an optional ffi_mangler ?
plicease
reviewed
Aug 2, 2019
| # ABSTRACT: Easily create interfaces to FFI functions with Moose roles | ||
|
|
||
| use Moose::Role; | ||
| use FFI::Platypus 0.89_01; |
There was a problem hiding this comment.
nit: please bump this to 0.90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[The MooseX::Role::FFI is provided here to make the review of both
easier to do at the same time. It will be released separately if
we were to approve this PR.]
The MooseX::Role::FFI allows to specify the subroutine data and the
library name - as well as the fallback - as subroutines.
It will then generate the corresponding callback for each sub, which
can be reached via a method.
The
afterallows us to have direct access to the FFI object beforethe callbacks are generated. (Which I think is when we need it for
the mangler to work, but I'm not sure.)
What I like about it:
it to it instead of subroutines.)
in _get_version and $HAS_SUBS)
What I don't like about it:
it being a definition of the class, not the instance.
because it's a string to retrieve it.
I'm not sure the benefits outweigh the drawbacks. I was thinking of
possibly providing another interface and saying "pick yours."